sendmail bug #2 (and fix)

[Jeff Stearns]

Subject: Sendmail can drop incoming mail from Berknet.

Index:	usr.lib/sendmail/src/{deliver,srvrsmtp}.c  4.2BSD

Description:
	The mail connection between Berknet and sendmail can be flakey.
	Incoming mail may be lost.  Complaints from MAILER-DAEMON may or
	may not be generated.

	N.B. this problem is related but not identical to the `bug' fixed
	in version 4.21 (11/1/83) of /bin/mail.

Repeat-By:
	The following command should deliver the arbitrary message read from
	STDIN.  Instead, the message is neither accepted nor returned; there
	are vague complaints of "Bad usage" and the message is lost.
	    % /usr/lib/sendmail -v -T10-11 -oee -r <from> -h 1 <to>

Fix:
		----- /usr/src/usr.lib/sendmail/deliver.c -----
1370c1371,1391
>			/*
>			 *  FLUKE jps 5-Dec-83 -  Surely Eric had not intended
>			 *  	  the degenerate comparison statement.  An
>			 *	  assignment statement looks reasonable to me.
>			 *
>			 *	  We were led to this statement while tracking
>			 *	  down problems with mail received via Berknet.
>			 *	  Berknet mmail would invoke a command such as:
>			 *	     /usr/lib/sendmail -oee -r FROM -h 1 TO
>			 *	  	FROM = sender's name
>			 *	  	TO = recipient's name
>			 *	  The mail would not be delivered.  There would
>			 *	  be hints of a response from MAILER-DAEMON, but
>			 *	  it would never be returned.
>			 *	  
>			 *	  Including the sendmail flags `-v -d10-11' will
>			 *	  produce more helpful information.
>			 *	  
>			 */
>			ErrorMode = EM_MAIL;
---
<			ErrorMode == EM_MAIL;
===============================================================================
	----- /usr/src/usr.lib/sendmail/srvrsmtp.c -----
289c290,294
>				/*
>				 *  FLUKE jps 5-Dec-83 -  For a discussion of
>				 *	  this change, see comments in deliver.c
>				 */
>				ErrorMode = EM_MAIL;
---
<				ErrorMode == EM_MAIL;


		Jeff Stearns,  John Fluke Mfg. Co., Inc.
		P.O. Box C9090, Everett WA  98043
		...!decvax!microsoft!fluke!jeff