error handling bug in sendoff() of sendmail 5.65

DEMIZU Noritoshi demizu at nff.ncl.omron.co.jp
Sat May 18 22:47:53 AEST 1991


In article <1227 at nikhefh.nikhef.nl>
	e07 at nikhefh.nikhef.nl (Eric Wassenaar) writes:

 |Because unfortunately I was looking at an old version of sendmail,
 |in which messages were requeued by markfailure() only for EX_TEMPFAIL.
 |The latest versions indeed will requeue on status codes EX_TEMPFAIL,
 |EX_IOERR, and EX_OSERR in markfailure().

I should say again that I did not check sendmail 5.65 source code
carefully.  I only looked at 5.61 source code.

I'll post patch again to avoid confusion.  Is this correct patch?

 --- DEMIZU Noritoshi    OMRON Corporation

=====================================================================
*** src/deliver.c.ORG	Sat May  4 14:32:51 1991
--- src/deliver.c	Sat May  4 14:33:45 1991
***************
*** 600,606 ****
  
  	pid = openmailer(m, pvp, ctladdr, FALSE, &mfile, &rfile);
  	if (pid < 0)
! 		return (-1);
  
  	/*
  	**  Format and send message.
--- 600,606 ----
  
  	pid = openmailer(m, pvp, ctladdr, FALSE, &mfile, &rfile);
  	if (pid < 0)
! 		return ExitStat;
  
  	/*
  	**  Format and send message.
*** support/getloadavg.c.ORG	Sat May  4 15:58:47 1991
--- support/getloadavg.c	Sat May  4 15:58:59 1991
***************
*** 42,47 ****
  			return (-1);
  	}
  	if (lseek(kmem, (off_t) Nl[X_AVENRUN].n_value, 0) == -1 ||
! 	    read(kmem, (char *) avenrun, sizeof(avenrun)) < sizeof(avenrun))
  		return (-1);
  }
--- 42,47 ----
  			return (-1);
  	}
  	if (lseek(kmem, (off_t) Nl[X_AVENRUN].n_value, 0) == -1 ||
! 	    read(kmem, (char *) avenrun, sizeof(*avenrun)) < sizeof(*avenrun))
  		return (-1);
  }
=====================================================================
--
;  DEMIZU, Noritoshi		OMRON Computer Systems R&D laboratory
;  demizu at nff.ncl.omron.co.jp	tel: 075-951-5111  fax: 075-956-7403



More information about the Comp.bugs.4bsd.ucb-fixes mailing list