rn bug #25

[Larry Wall]

System: rn version 4.1
Bug #: 25
Priority: LOW
Subject: some globals are missing their EXT
From: apwh!cbdkc1.UUCP

Description:
	Certain globals should be declared EXT but aren't.  This gives
	heartburn to certain compilers.

Repeat-By:
	If when you compile rn you get complaints about multiply defined
	globals, you may have this problem.

Fix:	From rn, say "| patch -d DIR", where DIR is your rn source directory.
	Outside of rn, say "cd DIR; patch <thisarticle".  If you don't have
	the patch program, apply the following by hand, or get patch.

Index: only.h
Prereq: 4.1
***************
*** 1,4
! /* $Header: only.h,v 4.1 84/09/24 12:04:15 lwall Exp $
   *
   * $Log:	only.h,v $
   * Revision 4.1  84/09/24  12:04:15  lwall

--- 1,4 -----
! /* $Header: only.h,v 4.1.1.2 84/11/30 16:37:29 lwall Exp $
   *
   * $Log:	only.h,v $
   * Revision 4.1.1.2  84/11/30  16:37:29  lwall
***************
*** 1,6
  /* $Header: only.h,v 4.1 84/09/24 12:04:15 lwall Exp $
   *
   * $Log:	only.h,v $
   * Revision 4.1  84/09/24  12:04:15  lwall
   * Real baseline.
   * 

--- 1,12 -----
  /* $Header: only.h,v 4.1.1.2 84/11/30 16:37:29 lwall Exp $
   *
   * $Log:	only.h,v $
+  * Revision 4.1.1.2  84/11/30  16:37:29  lwall
+  * EXT was missing from globals.
+  * 
+  * Revision 4.1.1.1  84/09/25  13:25:29  lwall
+  * Branch for sdcrdcf changes.
+  * 
   * Revision 4.1  84/09/24  12:04:15  lwall
   * Real baseline.
   * 
***************
*** 17,23
  #endif
  
  #ifdef ONLY
!     char *ngtodo[NGMAX];		/* restrictions in effect */
  #   ifdef SPEEDOVERMEM
  	COMPEX *compextodo[NGMAX];	/* restrictions in compiled form */
  #   endif

--- 23,29 -----
  #endif
  
  #ifdef ONLY
!     EXT char *ngtodo[NGMAX];		/* restrictions in effect */
  #   ifdef SPEEDOVERMEM
  	EXT COMPEX *compextodo[NGMAX];	/* restrictions in compiled form */
  #   endif
***************
*** 19,25
  #ifdef ONLY
      char *ngtodo[NGMAX];		/* restrictions in effect */
  #   ifdef SPEEDOVERMEM
! 	COMPEX *compextodo[NGMAX];	/* restrictions in compiled form */
  #   endif
  #endif
  

--- 25,31 -----
  #ifdef ONLY
      EXT char *ngtodo[NGMAX];		/* restrictions in effect */
  #   ifdef SPEEDOVERMEM
! 	EXT COMPEX *compextodo[NGMAX];	/* restrictions in compiled form */
  #   endif
  #endif
  
***************
*** 23,29
  #   endif
  #endif
  
! int maxngtodo INIT(0);			/*  0 => no restrictions */
  					/* >0 => # of entries in ngtodo */
  
  void	only_init();

--- 29,35 -----
  #   endif
  #endif
  
! EXT int maxngtodo INIT(0);			/*  0 => no restrictions */
  					/* >0 => # of entries in ngtodo */
  
  void	only_init();

Index: rcln.h
Prereq: 4.1
***************
*** 1,4
! /* $Header: rcln.h,v 4.1 84/09/24 12:04:59 lwall Exp $
   *
   * $Log:	rcln.h,v $
   * Revision 4.1  84/09/24  12:04:59  lwall

--- 1,4 -----
! /* $Header: rcln.h,v 4.1.1.2 84/11/30 16:36:44 lwall Exp $
   *
   * $Log:	rcln.h,v $
   * Revision 4.1.1.2  84/11/30  16:36:44  lwall
***************
*** 1,6
  /* $Header: rcln.h,v 4.1 84/09/24 12:04:59 lwall Exp $
   *
   * $Log:	rcln.h,v $
   * Revision 4.1  84/09/24  12:04:59  lwall
   * Real baseline.
   * 

--- 1,12 -----
  /* $Header: rcln.h,v 4.1.1.2 84/11/30 16:36:44 lwall Exp $
   *
   * $Log:	rcln.h,v $
+  * Revision 4.1.1.2  84/11/30  16:36:44  lwall
+  * EXT was missing from ngmax.
+  * 
+  * Revision 4.1.1.1  84/09/25  13:25:39  lwall
+  * Branch for sdcrdcf changes.
+  * 
   * Revision 4.1  84/09/24  12:04:59  lwall
   * Real baseline.
   * 
***************
*** 16,22
   */
  
  #ifdef DEBUGGING
! ART_NUM ngmax[MAXRCLINE];
  #endif
  
  void    rcln_init();

--- 22,28 -----
   */
  
  #ifdef DEBUGGING
! EXT ART_NUM ngmax[MAXRCLINE];
  #endif
  
  void    rcln_init();