more featureful popup

[David R. Blythe]

In article <1991Feb21.230936.9038 at jarvis.csri.toronto.edu> drb at eecg.toronto.edu (David R. Blythe) writes:
>that I find useful.  Its in the subdirectory pub/clsc.  It has been tested
>on a few different machines (GT/GTX) but not PI's and VGX's so caveat
>emptor.  Comments and bug fixes are welcome.

It didn't take long to uncover the first PI bug.  Line drawing using the
cmov2i()/draw2i() combination on the 4D/25TG in PUPDRAW mode seems to cause some
random scribbling under 3.3.1.  I have changed the code to use
bgnline()/endline() and it appears to work properly (which I should have done
in the first place).  Thanks to David Serafini for bringing the bug to my
attention.  (He also tells me that it breaks on a 340VGX too - hopefully this
fixes it too - I don't have access to a VGX machine to test).  The ftp'able
version has been updated or you can patch it yourself (diffs follow).

	david blythe
	ontario centre for large scale computation
	drb at clsc.utoronto.ca


RCS file: RCS/pup.c,v
retrieving revision 1.2
diff -c -r1.2 pup.c
*** /tmp/,RCSt1a17071	Fri Feb 22 18:30:10 1991
--- pup.c	Fri Feb 22 18:29:43 1991
***************
*** 728,735 ****
  	    color(PUP_BLACK);
  	}
  	if (e->flags&F_ULINE) {
! 	    cmov2i(menu->ox, menu->cy+EL_SLOP - i*EL_HEIGHT-HILIGHT_FUDGE);
! 	    draw2i(menu->cx, menu->cy+EL_SLOP - i*EL_HEIGHT-HILIGHT_FUDGE);
  	}
      }
  }
--- 728,737 ----
  	    color(PUP_BLACK);
  	}
  	if (e->flags&F_ULINE) {
!             int v[2];
! 	    v[0] = menu->ox;
! 	    v[1] = menu->cy+EL_SLOP - i*EL_HEIGHT-HILIGHT_FUDGE;
! 	    bgnline(); v2i(v); v[0] = menu->cx; v2i(v); endline();
  	}
      }
  }