bugs in news 2.10.1, advice to authors

[Jim Rees]

    There is a further minor bug in inews.c.
    At the start of localize(), the line

	actfp = fopen(ACTIVE, "r+");

    appears, and actfp is never tested to see if fopen succeeded.

Yes, I fixed that one here a while ago.  There isn't any really
sane thing to do at that point, so I made it an xerror().

In the same routine, there are two places where the function
will return without fcloseing ACTIVE, either.  Try submitting an
article with the following "Newsgroups:" line to rnews:

Newsgroups: general,a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z

Each of those invalid groups will leave a hanging FILE pointer, and
you will run out after just a few of them.  Granted this is a
pathological case, but I don't think it is wise to leave these
things open after they are needed.

The fix is to put a "fclose(actfp)" before each of the two "return FALSE"
statements.